Wasmtime GitHub notifications bot (Jan 23 2026 at 17:47): Wasmtime GitHub notifications bot (Jan 23 2026 at 17:47):alexcrichton requested rvolosatovs for a review on PR #12408.
Wasmtime GitHub notifications bot (Jan 23 2026 at 17:47):alexcrichton requested wasmtime-default-reviewers for a review on PR #12408.
Wasmtime GitHub notifications bot (Jan 23 2026 at 17:47):alexcrichton opened PR #12408 from alexcrichton:clarify-etiquette to bytecodealliance:main:
Document that we typically expect maintainers themselves to add their own PRs to the merge queue after approval, but clarify that for contributors this is a responsibility of maintainers to add PRs to the merge queue.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 23 2026 at 17:47):alexcrichton commented on PR #12408:
and folks can also feel free to disagree here and say "no approvers should add things to the merge queue" -- I just wish GitHub were better in that regard
Wasmtime GitHub notifications bot (Jan 23 2026 at 17:56):cfallin commented on PR #12408:
The branch-deletion bit is tricky (though I understand why GH does it). That said, I've shifted over the years but I tend to set auto-merge on straightforward PRs I approve even from core team members just to save everyone's time. You left it open either way here but I'm happy to stop doing that if folks want to claim the small joy of hitting the green button!
Wasmtime GitHub notifications bot (Jan 23 2026 at 18:00):rvolosatovs submitted PR review.
Wasmtime GitHub notifications bot (Jan 23 2026 at 18:26):fitzgen commented on PR #12408:
The branch-deletion bit is tricky (though I understand why GH does it). That said, I've shifted over the years but I tend to set auto-merge on straightforward PRs I approve even from core team members just to save everyone's time. You left it open either way here but I'm happy to stop doing that if folks want to claim the small joy of hitting the green button!
This is what I tend to do as well. If I approve, don't have any nitpicks/feedback to be addressed, and CI is green, I'll just enqueue it immediately.
But I can also stop doing this if we prefer not to.
Wasmtime GitHub notifications bot (Jan 23 2026 at 18:28):alexcrichton commented on PR #12408:
Heh ok in that case I don't want to have documentation saying "everyone should accomodate Alex doing his weird thing" so sounds like I should instead switch to merging PRs as well. I'll update the docs here to clarify
Wasmtime GitHub notifications bot (Jan 23 2026 at 19:45):github-actions[bot] added the label wasmtime:docs on PR #12408.
Wasmtime GitHub notifications bot (Jan 23 2026 at 21:09):alexcrichton updated PR #12408.
Wasmtime GitHub notifications bot (Jan 23 2026 at 21:10):alexcrichton commented on PR #12408:
Ok updated with a bit of text about "everyone should hit that green button" as well as orthogonal text explaining how merge queues work. Mind double-checking the words/meaning for me?
Wasmtime GitHub notifications bot (Jan 23 2026 at 21:14):cfallin submitted PR review:
Looks fine to me; thanks!
Wasmtime GitHub notifications bot (Jan 23 2026 at 21:15):cfallin commented on PR #12408:
(Despite the discussion here, not enabling auto-merge in case anyone else wants to add thoughts)
Wasmtime GitHub notifications bot (Jan 26 2026 at 14:16):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Jan 27 2026 at 02:07):alexcrichton added PR #12408 Clarify merge etiquette in Wasmtime to the merge queue.
Wasmtime GitHub notifications bot (Jan 27 2026 at 02:30):alexcrichton merged PR #12408.
Wasmtime GitHub notifications bot (Jan 27 2026 at 02:30):alexcrichton removed PR #12408 Clarify merge etiquette in Wasmtime from the merge queue.
Last updated: Jan 29 2026 at 13:25 UTC