Stream: git-wasmtime

Topic: wasmtime / PR #1239 Fill out CI docs in the contributing ...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 05 2020 at 21:50):

alexcrichton opened PR #1239 from ci-docs to master:

Figured it'd be good to document at least at a high level what in the
world is happening on all our PR runs.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 01:28):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 01:28):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 01:28):

fitzgen created PR Review Comment:

FWIW, it also makes sure that the fuzz targets themselves don't stop compiling.

A bit of an aside, but we were wondering whether it makes sense to keep testing a sampling of each target's corpus, and I think the answer is "yes" because running the actual samples takes very little time, and we want to keep building the fuzz targets in CI anyways (which is what takes most of the CI time) to make sure that the targets themselves don't break.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 05:14):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 05:14):

abrown created PR Review Comment:

Just a thought (since I saw @sunfishcode's update to cranelift docs): is this true for cranelift's docs as well?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:13):

alexcrichton updated PR #1239 from ci-docs to master:

Figured it'd be good to document at least at a high level what in the
world is happening on all our PR runs.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:13):

alexcrichton merged PR #1239.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:14):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 19:14):

alexcrichton created PR Review Comment:

It's definitely true for all crate documentation, but no long-form documentation is tested for cranelift right now I believe. (I don't think we even build and upload it b/c I didn't see it as part of cranelift's original CI either)


Last updated: Dec 23 2024 at 12:05 UTC