dicej requested alexcrichton for a review on PR #12380.
dicej opened PR #12380 from dicej:fix-wasmtime-wasi-http-p3 to bytecodealliance:main:
Recently, the WASIp3 tests in
wasmtime-wasi-httpstopped building, which we didn't notice because they weren't being built or run by CI. This fixes the damage and adds CI test coverage.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
dicej requested wasmtime-wasi-reviewers for a review on PR #12380.
dicej requested wasmtime-default-reviewers for a review on PR #12380.
rvolosatovs submitted PR review.
alexcrichton commented on PR #12380:
We do test the
p3feature in CI FWIW so everything runtime-passes, but the hole is that it's tested along with other crates which means that sibling packages might enable features that wasmtime-wasi-http relies on to build. This sort of PR is expected in that sense to be needed every now and then
I just realized this PR doesn't do what I said it does anyway. The CI change only enables
cargo checkcoverage.
dicej updated PR #12380.
Last updated: Jan 29 2026 at 13:25 UTC