Stream: git-wasmtime

Topic: wasmtime / PR #12365 Refactor defining core wasm async fu...

Wasmtime GitHub notifications bot (Jan 16 2026 at 20:44):

alexcrichton opened PR #12365 from alexcrichton:refactor-some-async to bytecodealliance:main:

There was some preexisting duplication between Func-related constructors and Linker-related constructors. This consolidates everything into HostFunc which duplicates type signatures a bit more but complexity-wise reduces the amount of internal duplication.

This additionally notably cuts down on usage of block_on literally, if not conceptually, which is going to eventually be important for rationalizing it with *_concurrent functions.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 16 2026 at 20:44):

alexcrichton requested wasmtime-core-reviewers for a review on PR #12365.

Wasmtime GitHub notifications bot (Jan 16 2026 at 20:44):

alexcrichton requested dicej for a review on PR #12365.

Wasmtime GitHub notifications bot (Jan 16 2026 at 20:45):

alexcrichton updated PR #12365.

Wasmtime GitHub notifications bot (Jan 16 2026 at 21:05):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Jan 16 2026 at 21:05):

dicej created PR review comment:

Why is this (and the other removed comes_from_same_engine assertions) no longer needed?

Wasmtime GitHub notifications bot (Jan 16 2026 at 21:38):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 16 2026 at 21:38):

alexcrichton created PR review comment:

Oh still needed, but amongst the layers here this assert was happening at every layer so I deleted all the duplicate ones to delegate to the lowest-level layers to perform the assertion

Wasmtime GitHub notifications bot (Jan 16 2026 at 21:39):

alexcrichton added PR #12365 Refactor defining core wasm async functions to the merge queue.

Wasmtime GitHub notifications bot (Jan 16 2026 at 22:03):

alexcrichton merged PR #12365.

Wasmtime GitHub notifications bot (Jan 16 2026 at 22:03):

alexcrichton removed PR #12365 Refactor defining core wasm async functions from the merge queue.

Last updated: Jan 29 2026 at 13:25 UTC