Stream: git-wasmtime

Topic: wasmtime / PR #12360 make async tests using `ready` inter...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2026 at 18:53):

dicej requested alexcrichton for a review on PR #12360.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2026 at 18:53):

dicej requested wasmtime-core-reviewers for a review on PR #12360.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2026 at 18:53):

dicej opened PR #12360 from dicej:fix-component-async-test-ready-interface to bytecodealliance:main:

This changes the ready interface used by component-async-tests from:

interface ready {
  // Set the `ready` state
  set-ready: func(ready: bool);
  // Block until `ready` is `true`
  when-ready: async func();
}

to:

interface ready {
  resource thing {
    constructor();
    set-ready: func(ready: bool);
    when-ready: async func();
  }
}

The problem with the original version was that it required global state and thus caused cross-talk across concurrent tasks. Due to implementation details inside Wasmtime, the tests worked anyway, but
https://github.com/bytecodealliance/wasmtime/pull/12357 perturbed that and revealed how fragile tests based on that interface were.

The new version puts the state inside a resource type, allowing each task create its own instance of that resource type and thereby avoid crosstalk.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2026 at 22:26):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2026 at 22:26):

dicej added PR #12360 make async tests using ready interface more robust to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2026 at 22:53):

dicej merged PR #12360.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2026 at 22:53):

dicej removed PR #12360 make async tests using ready interface more robust from the merge queue.


Last updated: Jan 29 2026 at 13:25 UTC