Wasmtime GitHub notifications bot (Jan 14 2026 at 18:22): Wasmtime GitHub notifications bot (Jan 14 2026 at 18:22):zzjas opened PR #12350 from zzjas:fix-heap-noexn-match to bytecodealliance:main:
HeapType::NoExn.matches()returns true for all types due to probably a typo in the fallthrough arm. Without the fix, the newly added test would fail with:thread 'types::heap_type_matches_noexn' (3801618) panicked at tests/all/types.rs:695:5: assertion failed: !HeapType::NoExn.matches(&HeapType::Func)Skipped raising an issue since it's quite trivial but please let me know if having an issue helps the bookkeeping. Thanks for looking into this!
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 14 2026 at 18:22):zzjas requested fitzgen for a review on PR #12350.
Wasmtime GitHub notifications bot (Jan 14 2026 at 18:22):zzjas requested wasmtime-core-reviewers for a review on PR #12350.
Wasmtime GitHub notifications bot (Jan 14 2026 at 18:45):alexcrichton submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Jan 14 2026 at 18:45):alexcrichton added PR #12350 Fix HeadType::matches fallthrough for NoExn to the merge queue.
Wasmtime GitHub notifications bot (Jan 14 2026 at 19:11):alexcrichton merged PR #12350.
Wasmtime GitHub notifications bot (Jan 14 2026 at 19:11):alexcrichton removed PR #12350 Fix HeadType::matches fallthrough for NoExn from the merge queue.
Last updated: Jan 29 2026 at 13:25 UTC