Stream: git-wasmtime

Topic: wasmtime / PR #12330 Update Func & TypedFunc's doc commen...

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:05):

rellfy opened PR #12330 from rellfy:call-concurrent-doc-comment to bytecodealliance:main.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:05):

rellfy requested fitzgen for a review on PR #12330.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:05):

rellfy requested wasmtime-core-reviewers for a review on PR #12330.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:15):

fitzgen created PR review comment:

    ///
    /// Concurrency is achieved by relying on the [`Accessor`] argument, which

This will ensure good formatting of the docs.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:15):

fitzgen submitted PR review:

Thanks for the docs! Some small nitpicks inline below.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:15):

fitzgen created PR review comment:

    /// # Example
    ///
    /// Using [`StoreContextMut::run_concurrent`] to get an [`Accessor`]:
    ///
    /// ```

This is not strictly necessary for formatting, but matches our existing style.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:15):

fitzgen created PR review comment:

Newlines to match our general style here as well.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:15):

fitzgen created PR review comment:

Newline here for formatting as well.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:15):

fitzgen created PR review comment:

Ditto regarding "foo" and all that here as well.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:15):

fitzgen created PR review comment:

Maybe call foo something more descriptive, especially since its definition is hidden via #. Perhaps my_typed_func or something?

Might make sense to show the get_typed_func call in this example.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:17):

rellfy updated PR #12330.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:18):

rellfy updated PR #12330.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:21):

rellfy updated PR #12330.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:22):

rellfy commented on PR #12330:

Thanks @fitzgen, I think I've applied all of the formatting suggestions.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:24):

rellfy updated PR #12330.

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:27):

fitzgen submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jan 13 2026 at 00:28):

fitzgen has enabled auto merge for PR #12330.

Wasmtime GitHub notifications bot (Jan 13 2026 at 01:46):

alexcrichton merged PR #12330.

Last updated: Jan 29 2026 at 13:25 UTC