Stream: git-wasmtime

Topic: wasmtime / PR #12322 clean up subtask in `starting` state...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2026 at 18:59):

dicej requested alexcrichton for a review on PR #12322.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2026 at 18:59):

dicej requested wasmtime-core-reviewers for a review on PR #12322.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2026 at 18:59):

dicej opened PR #12322 from dicej:fix-subtask-cancel-starting to bytecodealliance:main:

https://github.com/bytecodealliance/wasmtime/pull/12304 uncovered a bug which caused wit-bindgen's cancel-import test to hang. Specifically, cancelling a subtask that was in a starting state turned it into a zombie that never exited, meaning TaskExit::block would block forever without making progress.

This commit properly disposes of the subtask's thread and sets its exited field to true, which allows subtask_drop to delete it entirely. Additionally, I've updated test_cancel to call TaskExit::block to ensure this does not regress.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2026 at 19:09):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2026 at 19:37):

dicej merged PR #12322.


Last updated: Jan 29 2026 at 13:25 UTC