dicej requested alexcrichton for a review on PR #12322.
dicej requested wasmtime-core-reviewers for a review on PR #12322.
dicej opened PR #12322 from dicej:fix-subtask-cancel-starting to bytecodealliance:main:
https://github.com/bytecodealliance/wasmtime/pull/12304 uncovered a bug which caused
wit-bindgen'scancel-importtest to hang. Specifically, cancelling a subtask that was in astartingstate turned it into a zombie that never exited, meaningTaskExit::blockwould block forever without making progress.This commit properly disposes of the subtask's thread and sets its
exitedfield totrue, which allowssubtask_dropto delete it entirely. Additionally, I've updatedtest_cancelto callTaskExit::blockto ensure this does not regress.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton submitted PR review.
dicej merged PR #12322.
Last updated: Jan 29 2026 at 13:25 UTC