fitzgen opened PR #12309 from fitzgen:replace-anyhow-with-wasmtime-internal-error to bytecodealliance:main:
This replaces
wasmtime-environ's dependency onanyhow-- and its re-export of that crate aswasmtime_environ::error, which thewasmtimecrate re-exports aswasmtime::errorin turn -- with our ownwasmtime_internal_errorcrate. Our crate is API compatible withanyhow, but additionally allows for handling out-of-memory, memory-exhaustion, and allocation-failure errors.This will let us proceed with the efforts tracked in https://github.com/bytecodealliance/wasmtime/issues/12069
Builds on top of https://github.com/bytecodealliance/wasmtime/pull/12308
fitzgen requested wasmtime-wasi-reviewers for a review on PR #12309.
fitzgen requested dicej for a review on PR #12309.
fitzgen requested wasmtime-core-reviewers for a review on PR #12309.
fitzgen requested wasmtime-default-reviewers for a review on PR #12309.
fitzgen updated PR #12309.
fitzgen commented on PR #12309:
The
cargo vetfix included here is also split out into its own PR over here: https://github.com/bytecodealliance/wasmtime/pull/12310
alexcrichton commented on PR #12309:
I'd recommend
prtest:fullon this PR too to avoid merge-queue-based surprises
github-actions[bot] commented on PR #12309:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wizer"Thus the following users have been cc'd because of the following labels:
- fitzgen: wizer
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen updated PR #12309.
fitzgen requested wasmtime-fuzz-reviewers for a review on PR #12309.
fitzgen requested alexcrichton for a review on PR #12309.
fitzgen commented on PR #12309:
This PR depends on https://github.com/bytecodealliance/wasmtime/pull/12324 as well
github-actions[bot] commented on PR #12309:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen updated PR #12309.
fitzgen updated PR #12309.
fitzgen commented on PR #12309:
All of this PR's blockers have merged, I've rebased on
main, and addedprtest:fullto the commit message. All that is left is final review and this can merge.
fitzgen updated PR #12309.
fitzgen commented on PR #12309:
Found a bug in the wit-bindgen generated code with
anyhow: trueand peeled that off into https://github.com/bytecodealliance/wasmtime/pull/12334
fitzgen updated PR #12309.
fitzgen updated PR #12309.
fitzgen commented on PR #12309:
Depends on https://github.com/bytecodealliance/wasmtime/pull/12343
alexcrichton submitted PR review:
Looks like all that's left is a top-o sort of the
publish.rslist of crates, thanks again for pushing through all this and working on all the PRs!
fitzgen updated PR #12309.
fitzgen has enabled auto merge for PR #12309.
fitzgen added PR #12309 Replace anyhow with wasmtime_internal_error to the merge queue
fitzgen merged PR #12309.
fitzgen removed PR #12309 Replace anyhow with wasmtime_internal_error from the merge queue
Last updated: Jan 29 2026 at 13:25 UTC