cfallin opened PR #12302 from cfallin:fix-image-range to bytecodealliance:main:
This method is informational for embedders to be able to, for example, ensure an image in memory is
mlock'd (not swapped out). In the refactors around the StoreCode/EngineCode split, I mistakenly redefined this to only the text section. This is not a Wasm execution correctness issue but may lead to performance issues if an embedder relies on this behavior. This PR fixes the definition.Fixes #12284.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
cfallin requested fitzgen for a review on PR #12302.
cfallin requested wasmtime-core-reviewers for a review on PR #12302.
jeffcharles commented on PR #12302:
Can you also fix
image_rangeinComponent? It looks like it had the same change an implementation in #12051 and we also are using that method in wasmtime-rb.
jeffcharles edited a comment on PR #12302:
Can you also fix
image_rangeinComponent? It looks like it had the same change in implementation in #12051 and we also are using that method in wasmtime-rb.
alexcrichton submitted PR review:
r=me with @jeffcharles's comment
cfallin updated PR #12302.
cfallin commented on PR #12302:
Ah, missed that -- thanks!
cfallin has enabled auto merge for PR #12302.
cfallin updated PR #12302.
cfallin has enabled auto merge for PR #12302.
cfallin merged PR #12302.
Last updated: Jan 29 2026 at 13:25 UTC