Stream: git-wasmtime

Topic: wasmtime / PR #12302 Fix `Module::image_range` to include...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 08:27):

cfallin opened PR #12302 from cfallin:fix-image-range to bytecodealliance:main:

This method is informational for embedders to be able to, for example, ensure an image in memory is mlock'd (not swapped out). In the refactors around the StoreCode/EngineCode split, I mistakenly redefined this to only the text section. This is not a Wasm execution correctness issue but may lead to performance issues if an embedder relies on this behavior. This PR fixes the definition.

Fixes #12284.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 08:27):

cfallin requested fitzgen for a review on PR #12302.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 08:27):

cfallin requested wasmtime-core-reviewers for a review on PR #12302.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 15:01):

jeffcharles commented on PR #12302:

Can you also fix image_range in Component? It looks like it had the same change an implementation in #12051 and we also are using that method in wasmtime-rb.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 15:02):

jeffcharles edited a comment on PR #12302:

Can you also fix image_range in Component? It looks like it had the same change in implementation in #12051 and we also are using that method in wasmtime-rb.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 15:55):

alexcrichton submitted PR review:

r=me with @jeffcharles's comment

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 16:16):

cfallin updated PR #12302.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 16:17):

cfallin commented on PR #12302:

Ah, missed that -- thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 16:17):

cfallin has enabled auto merge for PR #12302.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 18:52):

cfallin updated PR #12302.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 18:53):

cfallin has enabled auto merge for PR #12302.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 09 2026 at 19:29):

cfallin merged PR #12302.


Last updated: Jan 29 2026 at 13:25 UTC