fitzgen opened PR #12294 from fitzgen:migrate-wasi-to-wasmtime-error to bytecodealliance:main:
Builds on top of https://github.com/bytecodealliance/wasmtime/pull/12293
fitzgen requested wasmtime-wasi-reviewers for a review on PR #12294.
fitzgen requested wasmtime-core-reviewers for a review on PR #12294.
fitzgen requested dicej for a review on PR #12294.
fitzgen requested wasmtime-default-reviewers for a review on PR #12294.
fitzgen updated PR #12294.
fitzgen updated PR #12294.
fitzgen updated PR #12294.
alexcrichton submitted PR review:
Might want to rebase before merging to prune out the extra commits too? I don't think it'll matter in the end but it'll help clean up the merge commit message too
fitzgen commented on PR #12294:
Might want to rebase before merging to prune out the extra commits too? I don't think it'll matter in the end but it'll help clean up the merge commit message too
I rebased a few PRs down the line, which cut a bunch of earlier commits out, don't really want to do O(n) rebases for such a deep stack, especially when I would have to wait for each PR to merge before rebasing the next. As you say, this just ends up including some old commit messages in the merge commit message, so not that big a deal IMO.
fitzgen merged PR #12294.
Last updated: Jan 29 2026 at 13:25 UTC