Stream: git-wasmtime

Topic: wasmtime / PR #12215 generate precise traps in component ...

Wasmtime GitHub notifications bot (Dec 23 2025 at 18:27):

dicej requested alexcrichton for a review on PR #12215.

Wasmtime GitHub notifications bot (Dec 23 2025 at 18:27):

dicej opened PR #12215 from dicej:fix-11683 to bytecodealliance:main:

Previously, we generated a generic unreachable instruction for each trap in a fused adapter, plus some metadata to recover the specific kind of trap. However, that metadata was never hooked up to anything, so we only got a generic unreachable message at runtime.

This commit removes the metadata tracking and instead simply calls a host intrinsic, passing the trap code as a parameter. This is somewhate pessimal compared with what we had before, but improves ergonomics and allows us to avoid forking as many tests from the component-model repo.

If performance becomes an issue, we can easily add an option to skip the host call and only emit an unreachable instruction as before.

Note that I've removed forked versions of three tests in favor of their upstream equivalents.

Fixes #11683

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 23 2025 at 18:27):

dicej requested wasmtime-compiler-reviewers for a review on PR #12215.

Wasmtime GitHub notifications bot (Dec 23 2025 at 18:27):

dicej requested wasmtime-core-reviewers for a review on PR #12215.

Wasmtime GitHub notifications bot (Dec 23 2025 at 18:36):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 23 2025 at 20:38):

dicej updated PR #12215.

Wasmtime GitHub notifications bot (Dec 23 2025 at 20:45):

dicej has enabled auto merge for PR #12215.

Wasmtime GitHub notifications bot (Dec 23 2025 at 20:47):

dicej updated PR #12215.

Wasmtime GitHub notifications bot (Dec 23 2025 at 21:23):

dicej merged PR #12215.

Last updated: Jan 09 2026 at 13:15 UTC