Wasmtime GitHub notifications bot (Dec 22 2025 at 20:49): Wasmtime GitHub notifications bot (Dec 22 2025 at 20:49):fitzgen requested alexcrichton for a review on PR #12208.
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:49):fitzgen requested wasmtime-core-reviewers for a review on PR #12208.
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:49):fitzgen opened PR #12208 from fitzgen:migrate-unwinder-to-environ-error to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:49):fitzgen requested wasmtime-default-reviewers for a review on PR #12208.
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:52):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:52):alexcrichton created PR review comment:
Personally I think this file transitioning is a good example of a bit of an ergonomic nightmare if this is what we use throughout the codebase. Using
anyhow::*inline is feasible given that it's so small to type, but I don't think that can be blanket-changed towasmtime_environ::error::*as that's quite the mouthful.Could this suggestion be used here or could the items be imported into this file?
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:52):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:59):fitzgen has enabled auto merge for PR #12208.
Wasmtime GitHub notifications bot (Dec 26 2025 at 19:43):fitzgen merged PR #12208.
Last updated: Jan 09 2026 at 13:15 UTC