Stream: git-wasmtime

Topic: wasmtime / PR #12204 `wasmtime-cranelift`: Use `wasmtime_...

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:27):

fitzgen opened PR #12204 from fitzgen:migrate-cranelift-to-environ-error to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:27):

fitzgen requested cfallin for a review on PR #12204.

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:27):

fitzgen requested wasmtime-default-reviewers for a review on PR #12204.

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:27):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #12204.

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:28):

fitzgen requested alexcrichton for a review on PR #12204.

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:38):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:38):

alexcrichton created PR review comment:

In the interest of keeping this pattern somewhat ergonomic, could each crate have crate::{Result, Error}, including wasmtime_environ, and that's what would be used here instead of the full path?

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:38):

alexcrichton created PR review comment:

Although, from an ergonomics perspective I also commonly use anyhow::bail!(...) in modules... Maybe add the error-related stuff to wasmtime{,_environ}::prelude which is commonly imported?

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:59):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 22 2025 at 20:59):

fitzgen created PR review comment:

I am just doing mechanical renamings right now, can do non-mechanical things in a follow up.

Wasmtime GitHub notifications bot (Dec 22 2025 at 21:09):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 22 2025 at 21:09):

alexcrichton created PR review comment:

Could you file an issue for this in that case? I'm afraid this is the kind of thing that'll get lost otherwise.

(also personally this is a major benefit of doing incremental PRs, figuring these things out as-things-are-developed instead of fixing them after-the-fact which more often than not leaves code in a half-done state)

Wasmtime GitHub notifications bot (Dec 22 2025 at 21:22):

fitzgen merged PR #12204.

Last updated: Jan 09 2026 at 13:15 UTC