Wasmtime GitHub notifications bot (Dec 22 2025 at 18:54): Wasmtime GitHub notifications bot (Dec 22 2025 at 18:54):fitzgen requested alexcrichton for a review on PR #12198.
Wasmtime GitHub notifications bot (Dec 22 2025 at 18:54):fitzgen opened PR #12198 from fitzgen:wasmtime-error-follow-ups to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 22 2025 at 18:54):fitzgen requested wasmtime-core-reviewers for a review on PR #12198.
Wasmtime GitHub notifications bot (Dec 22 2025 at 18:55):fitzgen edited PR #12198:
Addressing some feedback given in https://github.com/bytecodealliance/wasmtime/pull/12163#pullrequestreview-3599677121 after the PR merged.
Wasmtime GitHub notifications bot (Dec 22 2025 at 19:24):alexcrichton created PR review comment:
Oh I forgot, but for this you'll also want to tag
OomOrDynErrorbelow too so the base representation isNonNull<u8>which should get the ABI bits all lined up
Wasmtime GitHub notifications bot (Dec 22 2025 at 19:24):alexcrichton created PR review comment:
On second thought, this could be
return Ok(Box::new(MaybeUninit::uninit()))I believe -- with a comment saying that it's a ZST so no allocation actually happens.
Wasmtime GitHub notifications bot (Dec 22 2025 at 19:24):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 22 2025 at 19:29):fitzgen updated PR #12198.
Wasmtime GitHub notifications bot (Dec 22 2025 at 19:29):fitzgen has enabled auto merge for PR #12198.
Wasmtime GitHub notifications bot (Dec 22 2025 at 20:06):fitzgen merged PR #12198.
Last updated: Jan 09 2026 at 13:15 UTC