tobil4sk opened PR #12196 from tobil4sk:feature/cranelift-aarch64-fcmp to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->See: #4850
This implements
UnorderedOrLessThan,UnorderedOrLessThanOrEqual,UnorderedOrGreaterThan, andUnorderedOrGreaterThanOrEqual. I have not implementedOrderedNotEqualorUnorderedOrEqual, as it seems those require multiple conditions.I used the arm documentation as a reference: https://developer.arm.com/documentation/ddi0487/latest,
C1.2.4 Condition codeHere is a snippet of the relevant parts of the table:
Code Meaning (floating-point) Condition flags LT Less than or unordered N != V LE Less than, equal, or unordered !(Z == 0 && N == V) HI Greater than, or unordered C ==1 && Z == 0 PL Greater than, equal, or unordered N == 0 Apart from the tests fixed by this PR, I have also enabled the tests for Ordered and Unordered, which were already passing on aarch64 before but were disabled.
tobil4sk requested alexcrichton for a review on PR #12196.
tobil4sk requested wasmtime-compiler-reviewers for a review on PR #12196.
alexcrichton submitted PR review:
Thanks!
alexcrichton merged PR #12196.
Last updated: Jan 09 2026 at 13:15 UTC