Stream: git-wasmtime

Topic: wasmtime / PR #12189 Remove `--offline` from `publish.rs`

Wasmtime GitHub notifications bot (Dec 19 2025 at 18:53):

alexcrichton opened PR #12189 from alexcrichton:update-publish to bytecodealliance:main:

This was added in #12164 but I don't believe that it's necessary for that operation. That may change the lock file if the crates weren't previously vendored, so this enables using the network to fetch dependencies in the lock file that aren't present locally.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 19 2025 at 18:53):

alexcrichton requested dicej for a review on PR #12189.

Wasmtime GitHub notifications bot (Dec 19 2025 at 18:53):

alexcrichton requested wasmtime-default-reviewers for a review on PR #12189.

Wasmtime GitHub notifications bot (Dec 19 2025 at 19:15):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Dec 19 2025 at 21:47):

alexcrichton commented on PR #12189:

cc @fitzgen from https://github.com/bytecodealliance/wasmtime/pull/12164, wanted to make sure you had a chance to look at this too

Wasmtime GitHub notifications bot (Dec 19 2025 at 22:03):

fitzgen commented on PR #12189:

My goal was to not hit crates.io and potentially update crates in the lockfile when we were just trying to update the bumped versions in the lockfile. Quite possible I messed that up.

Wasmtime GitHub notifications bot (Dec 19 2025 at 22:20):

alexcrichton commented on PR #12189:

Ah ok makes sense. We do want to hit the network to fill out any packages that are in the lock file but not present locally, and Cargo by deafult, when updating versions, keeps the old lock file as much as possible. Given that it should be fine to drop --offline and when updating versions it shouldn't update versions of other unrelated dependencies. Did you see different behavior though?

Wasmtime GitHub notifications bot (Dec 22 2025 at 17:13):

fitzgen commented on PR #12189:

Did you see different behavior though?

Not sure, I was trying lots of different stuff, often at the same time (unscientifically).

Let's just move forward here and we can always add --offline back if we find a reason we need to.

Wasmtime GitHub notifications bot (Dec 22 2025 at 17:37):

fitzgen merged PR #12189.

Last updated: Jan 09 2026 at 13:15 UTC