Stream: git-wasmtime

Topic: wasmtime / PR #12160 Cranelift: make all non-tail, non-in...

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:21):

cfallin edited PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:21):

cfallin updated PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:44):

cfallin updated PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 11:45):

github-actions[bot] commented on PR #12160:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:meta", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 12 2025 at 20:50):

cfallin updated PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 20:50):

cfallin edited PR #12160:

As discussed in this week's Cranelift meeting, we've discovered a need to generalize the patchable_call mechanism and corresponding patchable ABI slightly. In particular, we will need patchable try_call callsites as well in order to allow breakpoint handlers to throw exceptions (desirable functionality eventually) and have this work in the presence of inlining. Also, it's just a nice generalization to say that patchability is an orthogonal dimension to the call ABI and the other restrictions we initially imposed, and works as long as the basic requirement (no return values) is met.

This also renames the patchable ABI to preserve_all, to make it clear that its purpose is actually orthogonal, and it can be used independently of patchable callsites. It also deletes the cold ABI, which never actually did anything and is misleading in the presence of an actual cold-ish (subzero temperature, actually) ABI like preserve_all.

Wasmtime GitHub notifications bot (Dec 12 2025 at 23:00):

cfallin updated PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 23:01):

cfallin updated PR #12160.

Wasmtime GitHub notifications bot (Dec 15 2025 at 19:19):

fitzgen submitted PR review:

LGTM, thanks for cleaning this up!

Wasmtime GitHub notifications bot (Dec 15 2025 at 19:19):

fitzgen created PR review comment:

Maybe a little cleaner (and more future proof, due to exhaustive matching?) to do destructuring here instead of repeated index+field access.

        let ir::ExtFuncData { patchable, colocated, signature, name: _ } = self.func.dfg.ext_funcs[func_ref];

Wasmtime GitHub notifications bot (Dec 15 2025 at 23:06):

cfallin updated PR #12160.

Wasmtime GitHub notifications bot (Dec 15 2025 at 23:06):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 15 2025 at 23:06):

cfallin created PR review comment:

Ah, of course, great point -- done in 4dc84bb7f7.

Wasmtime GitHub notifications bot (Dec 15 2025 at 23:07):

cfallin has enabled auto merge for PR #12160.

Wasmtime GitHub notifications bot (Dec 15 2025 at 23:53):

cfallin merged PR #12160.

Last updated: Jan 09 2026 at 13:15 UTC