Stream: git-wasmtime

Topic: wasmtime / PR #12160 Cranelift: make all non-tail calls p...

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:20):

cfallin opened PR #12160 from cfallin:patchability-is-not-an-instruction-its-a-way-of-life to bytecodealliance:main:

(Stacked on top of #12133.)

As discussed in this week's Cranelift meeting, we've discovered a need to generalize the patchable_call mechanism and corresponding patchable ABI slightly. In particular, we will need patchable try_call callsites as well in order to allow breakpoint handlers to throw exceptions (desirable functionality eventually) and have this work in the presence of inlining. Also, it's just a nice generalization to say that patchability is an orthogonal dimension to the call ABI and the other restrictions we initially imposed, and works as long as the basic requirement (no return values) is met.

This also renames the patchable ABI to preserve_all, to make it clear that its purpose is actually orthogonal, and it can be used independently of patchable callsites. It also deletes the cold ABI, which never actually did anything and is misleading in the presence of an actual cold-ish (subzero temperature, actually) ABI like preserve_all.

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:20):

cfallin requested wasmtime-compiler-reviewers for a review on PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:20):

cfallin requested fitzgen for a review on PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:20):

cfallin requested wasmtime-default-reviewers for a review on PR #12160.

Wasmtime GitHub notifications bot (Dec 12 2025 at 10:20):

cfallin requested wasmtime-core-reviewers for a review on PR #12160.

Last updated: Dec 13 2025 at 19:03 UTC