Stream: git-wasmtime

Topic: wasmtime / PR #1214 cranelift-module: expose trap informa...

Wasmtime GitHub notifications bot (Mar 05 2020 at 00:40):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Mar 05 2020 at 07:04):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 05 2020 at 07:04):

bjorn3 created PR Review Comment:

Please return &[TrapSite] instead.

Wasmtime GitHub notifications bot (Mar 05 2020 at 07:04):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 05 2020 at 07:06):

bjorn3 edited PR Review Comment.

Wasmtime GitHub notifications bot (Mar 05 2020 at 15:07):

froydnj updated PR #1214 from trap-exposure to master:

• [X] This has been discussed in issue #1184.
• [X] A short description of what this does, why it is needed: The current interface of cranelift-module requires consumers who want to be informed about traps to discover that information through Module::Product, which is backend-specific. Since it's advantageous to manipulate this information in a backend-agnostic way, this patch changes Module::define_function{,_bytes} to return information about the traps contained in the function being defined.
• [X] This PR does not contain test cases.
• [x] A reviewer from the core maintainer team has been assigned for this PR.

Wasmtime GitHub notifications bot (Mar 05 2020 at 15:14):

froydnj updated PR #1214 from trap-exposure to master:

• [X] This has been discussed in issue #1184.
• [X] A short description of what this does, why it is needed: The current interface of cranelift-module requires consumers who want to be informed about traps to discover that information through Module::Product, which is backend-specific. Since it's advantageous to manipulate this information in a backend-agnostic way, this patch changes Module::define_function{,_bytes} to return information about the traps contained in the function being defined.
• [X] This PR does not contain test cases.
• [x] A reviewer from the core maintainer team has been assigned for this PR.

Wasmtime GitHub notifications bot (Mar 05 2020 at 15:16):

froydnj submitted PR Review.

Wasmtime GitHub notifications bot (Mar 05 2020 at 15:16):

froydnj created PR Review Comment:

Good point, done.

Wasmtime GitHub notifications bot (Mar 05 2020 at 15:19):

froydnj updated PR #1214 from trap-exposure to master:

• [X] This has been discussed in issue #1184.
• [X] A short description of what this does, why it is needed: The current interface of cranelift-module requires consumers who want to be informed about traps to discover that information through Module::Product, which is backend-specific. Since it's advantageous to manipulate this information in a backend-agnostic way, this patch changes Module::define_function{,_bytes} to return information about the traps contained in the function being defined.
• [X] This PR does not contain test cases.
• [x] A reviewer from the core maintainer team has been assigned for this PR.

Wasmtime GitHub notifications bot (Mar 05 2020 at 22:17):

pchickey merged PR #1214.

Last updated: Dec 23 2024 at 12:05 UTC