Stream: git-wasmtime

Topic: wasmtime / PR #1213 Remove file-per-thread-logger support...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 04 2020 at 15:32):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 04 2020 at 15:32):

alexcrichton created PR Review Comment:

That seems reasonable, yeah, but do you know what it would be set to by default? I feel like debug is a bit too verbose with lots of debug information about cranelift coming out? We could maybe set wasmtime=debug but I'm not sure how useful that would be...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 04 2020 at 19:11):

peterhuene submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 04 2020 at 19:11):

peterhuene created PR Review Comment:

If wasmtime=debug doesn't offer anything useful, I would argue just for debug and let users drink from the fire hose; it's always possible for them to tailor it by setting RUST_LOG manually.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 04 2020 at 19:47):

alexcrichton closed without merge PR #1213.


Last updated: Oct 23 2024 at 20:03 UTC