Stream: git-wasmtime

Topic: wasmtime / PR #12117 trap on read from and write to intra...

Wasmtime GitHub notifications bot (Dec 03 2025 at 16:56):

dicej requested alexcrichton for a review on PR #12117.

Wasmtime GitHub notifications bot (Dec 03 2025 at 16:56):

dicej opened PR #12117 from dicej:fix-12108 to bytecodealliance:main:

The spec says we need to do this for streams and futures that have a payload type.

Note that p3_http_middleware_host_to_host triggers this trap, which is expected given how it functions, so now we assert accordingly.

Thanks to Alex for the tests!

Fixes #12108

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 03 2025 at 16:56):

dicej requested wasmtime-wasi-reviewers for a review on PR #12117.

Wasmtime GitHub notifications bot (Dec 03 2025 at 16:56):

dicej requested wasmtime-core-reviewers for a review on PR #12117.

Wasmtime GitHub notifications bot (Dec 03 2025 at 17:24):

alexcrichton commented on PR #12117:

How invasive would it be to update the echo component to make a new stream and do the copy itself? This is the kind of test that's unlikely to ever be un-gated given how buried it is otherwise

Wasmtime GitHub notifications bot (Dec 03 2025 at 17:28):

dicej commented on PR #12117:

How invasive would it be to update the echo component to make a new stream and do the copy itself? This is the kind of test that's unlikely to ever be un-gated given how buried it is otherwise

It already knows how to do that: https://github.com/bytecodealliance/wasmtime/blob/main/crates/test-programs/src/bin/p3_http_echo.rs. It can either return the original stream or use an intermediate one, depending on whether a certain header is present. We test it both ways, and only one of the ways traps.

Wasmtime GitHub notifications bot (Dec 03 2025 at 17:48):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 03 2025 at 18:47):

alexcrichton merged PR #12117.

Last updated: Dec 06 2025 at 07:03 UTC