Wasmtime GitHub notifications bot (Dec 03 2025 at 16:30): Wasmtime GitHub notifications bot (Dec 03 2025 at 16:30):fitzgen opened PR #12116 from fitzgen:revert-isle-rule to bytecodealliance:main:
This reverts commit 72534b0f9783570936c83e291e1abdbe7f5e6793.
This mid-end rule was shown to be the root cause of a codegen regression in https://github.com/bytecodealliance/wasmtime/issues/12106 and we didn't have any real examples that would improve from this rule, just a theoretical idea of its benefit. Better to do actual instruction scheduling while lowering and/or during regalloc than to do hack-y instruction scheduling in the mid-end (where we have no idea how many registers are available, for example).
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 03 2025 at 16:30):fitzgen requested wasmtime-compiler-reviewers for a review on PR #12116.
Wasmtime GitHub notifications bot (Dec 03 2025 at 16:30):fitzgen requested alexcrichton for a review on PR #12116.
Wasmtime GitHub notifications bot (Dec 03 2025 at 16:30):fitzgen requested cfallin for a review on PR #12116.
Wasmtime GitHub notifications bot (Dec 03 2025 at 18:51):github-actions[bot] commented on PR #12116:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 03 2025 at 19:05):cfallin submitted PR review:
LGTM, thanks!
(Looks like some disas tests will need re-blessing as well to pass CI.)
Wasmtime GitHub notifications bot (Dec 03 2025 at 21:17):fitzgen updated PR #12116.
Wasmtime GitHub notifications bot (Dec 03 2025 at 21:17):fitzgen requested wasmtime-core-reviewers for a review on PR #12116.
Wasmtime GitHub notifications bot (Dec 03 2025 at 21:17):fitzgen requested pchickey for a review on PR #12116.
Wasmtime GitHub notifications bot (Dec 03 2025 at 21:17):fitzgen has enabled auto merge for PR #12116.
Wasmtime GitHub notifications bot (Dec 03 2025 at 21:54):fitzgen merged PR #12116.
Last updated: Dec 06 2025 at 07:03 UTC