Stream: git-wasmtime

Topic: wasmtime / PR #1208 Add load_extend instructions for x86 ...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2020 at 17:28):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2020 at 17:28):

abrown created PR Review Comment:

Figured this out: the uload* instructions need to have encodings not just for the fld recipe but also fldDisp8 and fldDisp32.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2020 at 17:51):

abrown updated PR #1208 from load-extend-rebased to master:

This change adds Wasm SIMD [load extend] functionality to the x86 backend by adding new Cranelift instructions for each Wasm SIMD instruction. This closes #1176.

[load extend]: https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#load-and-extend

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2020 at 17:52):

abrown requested julian-seward1 for a review on PR #1208.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2020 at 18:35):

abrown updated PR #1208 from load-extend-rebased to master:

This change adds Wasm SIMD [load extend] functionality to the x86 backend by adding new Cranelift instructions for each Wasm SIMD instruction. This closes #1176.

[load extend]: https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#load-and-extend

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 08:42):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 08:42):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 17:21):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 17:21):

abrown created PR Review Comment:

I think you are right, it would be more explicit but that would be inconsistent with sload8, uload16, etc.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 17:22):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 17:22):

abrown created PR Review Comment:

I actually removed this commit and @bnjbvr is reviewing it separately in https://github.com/bytecodealliance/wasmtime/pull/1191.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 17:22):

abrown updated PR #1208 from load-extend-rebased to master:

This change adds Wasm SIMD [load extend] functionality to the x86 backend by adding new Cranelift instructions for each Wasm SIMD instruction. This closes #1176.

[load extend]: https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#load-and-extend

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 18:35):

abrown merged PR #1208.

Last updated: Dec 23 2024 at 12:05 UTC