Stream: git-wasmtime

Topic: wasmtime / PR #12074 Add missing `gc` feature gates

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:03):

primoly opened PR #12074 from primoly:gate-gc to bytecodealliance:main:

Add missing gc feature gates.

Fixes #12071

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:03):

primoly requested wasmtime-core-reviewers for a review on PR #12074.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:03):

primoly requested alexcrichton for a review on PR #12074.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:20):

primoly submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:20):

primoly created PR review comment:

This function is only called when the gc feature is enabled, so I removed the debug gate (it produced a warning). But maybe this was intentional, as it may be needed with the debug feature in the future. Should I revert this back? The PR that introduced the function is #11769

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:21):

primoly deleted PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:22):

primoly submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 23 2025 at 14:22):

primoly created PR review comment:

This function is only called when the gc feature is enabled, so I removed the debug gate (it produced a warning). But maybe this was intentional as it may be needed with the debug feature in the future. Should I revert this back? The PR that introduced the function is #11769

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 15:01):

alexcrichton submitted PR review:

Thanks! Could you also extend the list of checks here with the combination that didn't build? (to help ensure no future regressions)

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 15:01):

alexcrichton created PR review comment:

Nah that's ok, we basically just frob things until warnings and such go away

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 16:12):

primoly requested fitzgen for a review on PR #12074.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 16:12):

primoly updated PR #12074.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 16:12):

primoly requested wasmtime-default-reviewers for a review on PR #12074.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 16:20):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 16:20):

alexcrichton has enabled auto merge for PR #12074.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2025 at 17:22):

alexcrichton merged PR #12074.

Last updated: Dec 06 2025 at 06:05 UTC