alexcrichton opened PR #12018 from alexcrichton:release-36.0.0 to bytecodealliance:release-36.0.0:
This commit fixes a few issues where it was possible to represent a wasm shared linear memory with the
wasmtime::Memorytype. This is not sound becausewasmtime::Memoryprovides safe Rust access to the bytes where that is not possible with wasm shared memories. Shared memories in Rust must be represented bySharedMemory, notwasmtime::Memory.Specifically this commit prevents two vectors of this happening:
Memory::newnow requires that the memory type specified is non-shared. InsteadSharedMemory::newmust be used instead.Core dumps now skip over shared memories when iterating over all memories in the store. Supporting shared memories is a more invasive change and will happen on Wasmtime's
mainbranch.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested dicej for a review on PR #12018.
alexcrichton requested wasmtime-core-reviewers for a review on PR #12018.
alexcrichton requested wasmtime-default-reviewers for a review on PR #12018.
alexcrichton updated PR #12018.
alexcrichton commented on PR #12018:
Carrying over @pchickey's approval from the security advisory.
alexcrichton merged PR #12018.
Last updated: Dec 06 2025 at 06:05 UTC