Stream: git-wasmtime

Topic: wasmtime / PR #11998 [Cranelift] `min x y < y => false`

Wasmtime GitHub notifications bot (Nov 07 2025 at 06:05):

bongjunj opened PR #11998 from bongjunj:select_min_gt_eqv_false to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 07 2025 at 06:05):

bongjunj requested cfallin for a review on PR #11998.

Wasmtime GitHub notifications bot (Nov 07 2025 at 06:05):

bongjunj requested wasmtime-compiler-reviewers for a review on PR #11998.

Wasmtime GitHub notifications bot (Nov 07 2025 at 06:14):

bongjunj updated PR #11998.

Wasmtime GitHub notifications bot (Nov 07 2025 at 08:48):

github-actions[bot] commented on PR #11998:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Nov 07 2025 at 17:51):

cfallin submitted PR review:

LGTM, thanks!

Would you mind generalizing with a few more cases?

• Unsigned min and unsigned comparisons should work too, right?
• Could we do the commutative cases (slt/ult and min second) as well?

Wasmtime GitHub notifications bot (Nov 08 2025 at 02:44):

bongjunj updated PR #11998.

Wasmtime GitHub notifications bot (Nov 08 2025 at 02:46):

bongjunj commented on PR #11998:

thanks for the comment. I have included the commutative cases as well as the flipped comparison cases.

Wasmtime GitHub notifications bot (Nov 08 2025 at 03:29):

cfallin commented on PR #11998:

Thanks! I think there are twice as many rules as needed now though, if I'm not mistaken: e.g.,

(rule (simplify (sgt ty (smin _ x y) x)) (iconst_u ty 0)) (line 105)

is isomorphic to

(rule (simplify (sgt ty (smin _ y x) y)) (iconst_u ty 0)) (line 109)

up to variable renaming, right?

Wasmtime GitHub notifications bot (Nov 08 2025 at 03:35):

bongjunj commented on PR #11998:

Oh that's true. Will fix it shortly. Thanks!

Wasmtime GitHub notifications bot (Nov 08 2025 at 03:52):

bongjunj updated PR #11998.

Wasmtime GitHub notifications bot (Nov 08 2025 at 06:34):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 08 2025 at 07:00):

cfallin merged PR #11998.

Last updated: Dec 06 2025 at 06:05 UTC