Stream: git-wasmtime

Topic: wasmtime / PR #11986 Use `OptionsIndex` more internally i...

Wasmtime GitHub notifications bot (Nov 05 2025 at 19:22):

alexcrichton requested dicej for a review on PR #11986.

Wasmtime GitHub notifications bot (Nov 05 2025 at 19:22):

alexcrichton opened PR #11986 from alexcrichton:less-options-passing to bytecodealliance:main:

This updates various runtimes bits for components to use OptionsIndex more aggressively and ultimately deletes the old Options type. The Options type is a heavyweight package of all possible options which is effectively a duplication of what OptionsIndex points to, so that's removed in favor of directly accessing options.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 05 2025 at 19:22):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11986.

Wasmtime GitHub notifications bot (Nov 05 2025 at 19:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 05 2025 at 19:23):

alexcrichton created PR review comment:

@dicej your scrutiny here would be appreciated. I'm relatively sure this removal is "accurate", but I'm not sure if it should cascade in more removals as well (e.g. instance => _instance above as opposed to removing it entirely)

Wasmtime GitHub notifications bot (Nov 10 2025 at 16:28):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2025 at 16:28):

dicej created PR review comment:

Looks reasonable to me, and I would indeed cascade the removals. No point in passing unused parameters around.

Wasmtime GitHub notifications bot (Nov 10 2025 at 18:23):

alexcrichton closed without merge PR #11986.

Wasmtime GitHub notifications bot (Nov 10 2025 at 18:24):

alexcrichton commented on PR #11986:

Oops I accidentally landed this in https://github.com/bytecodealliance/wasmtime/pull/11987 without intending to... Given that I'll close this, and the follow-up work is at https://github.com/bytecodealliance/wasmtime/pull/12013

Last updated: Dec 06 2025 at 06:05 UTC