Wasmtime GitHub notifications bot (Nov 04 2025 at 20:17): Wasmtime GitHub notifications bot (Nov 04 2025 at 20:17):dicej requested alexcrichton for a review on PR #11980.
Wasmtime GitHub notifications bot (Nov 04 2025 at 20:17):dicej opened PR #11980 from dicej:remove-redundant-event to bytecodealliance:main:
Previously, we sent this event both immediately after lowering parameters and when the async-with-callback-lifted export returned. The latter was redundant, but it didn't matter in most cases because the second event usually overwrote the first one such that it was only delivered once. However, in cases of three or more components composed together, both events got delivered, and that made
wit-bindgenjustifiably upset.This removes the redundant event and adds a three component composition test to cover the scenario.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 04 2025 at 20:17):dicej requested wasmtime-core-reviewers for a review on PR #11980.
Wasmtime GitHub notifications bot (Nov 04 2025 at 20:22):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Nov 04 2025 at 20:29):dicej has enabled auto merge for PR #11980.
Wasmtime GitHub notifications bot (Nov 04 2025 at 21:02):dicej merged PR #11980.
Last updated: Dec 06 2025 at 07:03 UTC