Wasmtime GitHub notifications bot (Nov 01 2025 at 16:40): Wasmtime GitHub notifications bot (Nov 01 2025 at 16:40):alexcrichton opened PR #11961 from alexcrichton:improve-header-management to bytecodealliance:main:
This commit improves the management of header files in cmake to pick up changes to them after-configure in some situations. Previously the cmake scripts would copy all wasmtime headers into the build directory to live adjacent to the
conf.h-generated header. This meant that there was only one-Idirectory, for example, but it meant that changes to the source files after configuration weren't reflected in the output. This commit fixes this by leaving the source headers in-place. This means that there are now two include directories during building.Various rules/targets should all be updated to handle this, and notably the build script of the C API still copies headers around as it did before (when built via Rust).
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 01 2025 at 16:40):alexcrichton requested pchickey for a review on PR #11961.
Wasmtime GitHub notifications bot (Nov 01 2025 at 16:40):alexcrichton requested wasmtime-core-reviewers for a review on PR #11961.
Wasmtime GitHub notifications bot (Nov 03 2025 at 17:57):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 03 2025 at 18:25):alexcrichton merged PR #11961.
Last updated: Dec 06 2025 at 06:05 UTC