bnjbvr requested bnjbvr for a review on PR #1196.
bnjbvr submitted PR Review.
csmoe updated PR #1196 from safepoint
to master
:
Closes #1156
r? @bnjbvr
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
What about using references as function parameters, but not using them anywhere? This would skip them.
bjorn3 created PR Review Comment:
The error is reported during regalloc, not during the verifier pass.
bjorn3 submitted PR Review.
@bjorn3 as you said, this check happens in regalloc, not verifier. So should I add an Error variant for it? https://github.com/bytecodealliance/wasmtime/blob/master/cranelift/codegen/src/result.rs#L10
I don't think that is necessary. Maybe move the error to the verifier though, as this is the kind of error emitted by the verifier.
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
Good point! I think a few tests actually need to be added:
- for function parameters
- for EBB params
- for value types in signature refs
Can you add the code and tests for this, please? Thanks!
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
There should be an error annotation in this test, so it'd check that the verifier asserts because a ref type is used yet ref types aren't enabled, right?
alexcrichton edited PR #1196 from safepoint
to main
:
Closes #1156
r? @bnjbvr
cfallin closed without merge PR #1196.
Last updated: Dec 23 2024 at 12:05 UTC