Stream: git-wasmtime

Topic: wasmtime / PR #11941 wasi-http: use UnsyncBoxBody to supp...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2025 at 22:20):

jellevandenhooff opened PR #11941 from jellevandenhooff:wasi-http-p3-unsync-box-body to bytecodealliance:main:

This is a bit of a drive-by PR -- I do not entirely know what I am doing and am very open to pointers or feedback.

This PR replaces the BoxBody used in the p3 wasi-http implementation with UnsyncBoxBody. It is the same type, without the Sync constraint. The axum framework uses UnsyncBoxBody everywhere and is not compatible with the conversion functions in the p3 crate otherwise.

Since axum already happily uses the UnsyncBoxBody internally, I would guess it is a reasonable choice to use here, but I am not sure.

I tested code by running cargo test --features=p3 in the wasi-http crate, and cargo test all serve for the CLI. I also got my own code locally to work against this branch and was able to forward an axum request to a wasm handler.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2025 at 22:20):

jellevandenhooff requested wasmtime-wasi-reviewers for a review on PR #11941.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2025 at 22:20):

jellevandenhooff requested alexcrichton for a review on PR #11941.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2025 at 22:20):

jellevandenhooff requested wasmtime-core-reviewers for a review on PR #11941.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2025 at 10:07):

rvolosatovs submitted PR review:

Looks good to me, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2025 at 10:32):

rvolosatovs merged PR #11941.

Last updated: Dec 06 2025 at 07:03 UTC