Stream: git-wasmtime

Topic: wasmtime / PR #11935 Reduce scope of scratch registers fo...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 16:17):

jeffcharles opened PR #11935 from jeffcharles:fix-scratch-issue-with-shifts to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Fixes #11868.

Narrows the scope of using the general purpose scratch register and the floating point scratch register so that allocating new registers happen outside those scopes. The reason that fixes the issue is register allocation can trigger a spill if the all registers of the desired type are allocated and spilling requires a scratch register to move locals into memory.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 16:17):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #11935.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 16:17):

jeffcharles requested wasmtime-core-reviewers for a review on PR #11935.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 16:17):

jeffcharles requested fitzgen for a review on PR #11935.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 16:17):

jeffcharles commented on PR #11935:

cc @saulecabrera

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 17:45):

github-actions[bot] commented on PR #11935:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 20:49):

saulecabrera submitted PR review:

LGTM, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2025 at 21:13):

saulecabrera merged PR #11935.


Last updated: Jan 09 2026 at 13:15 UTC