Wasmtime GitHub notifications bot (Oct 24 2025 at 15:30): Wasmtime GitHub notifications bot (Oct 24 2025 at 15:30):alexcrichton opened PR #11933 from alexcrichton:ghsa-38 to bytecodealliance:release-38.0.0:
This commit updates the implementation of compiling array-to-wasm trampolines for component intrinsics to reuse the exact same implementation as core wasm uses. This fixes an issue where the component trampolines were not updated as part of #11592 to have a try/catch for errors that happen during their execution.
The implementation here is intended to be a small, backportable, patch to the 38.0.x release branch. This does not refactor, for example,
TrampolineCompilerwhich now always uses theWasmABI as opposed to using either the wasm or array ABI. Such cleanup is left for a follow-up PR tomainafter this one.In the meantime though the implementation of array-ABI component model intrinsics now looks exactly like array-to-wasm trampolines for core wasm where the array-ABI function performs a
try_callto the wasm-ABI function, letting the wasm-ABI function doing the actual work. This is a nice simplification for trampolines where the definition of the trampoline is now just in one function instead of duplicated across two.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 24 2025 at 15:30):alexcrichton requested cfallin for a review on PR #11933.
Wasmtime GitHub notifications bot (Oct 24 2025 at 15:30):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11933.
Wasmtime GitHub notifications bot (Oct 24 2025 at 15:30):alexcrichton requested fitzgen for a review on PR #11933.
Wasmtime GitHub notifications bot (Oct 24 2025 at 15:30):alexcrichton requested wasmtime-core-reviewers for a review on PR #11933.
Wasmtime GitHub notifications bot (Oct 24 2025 at 16:55):alexcrichton has enabled auto merge for PR #11933.
Wasmtime GitHub notifications bot (Oct 24 2025 at 21:07):alexcrichton has disabled auto merge for PR #11933.
Wasmtime GitHub notifications bot (Oct 24 2025 at 21:07):alexcrichton merged PR #11933.
Wasmtime GitHub notifications bot (Oct 24 2025 at 21:08):alexcrichton commented on PR #11933:
Merging as @fitzgen pre-reviewed this and I suspect folks are otherwise busy in meetings most of today or such.
Wasmtime GitHub notifications bot (Oct 24 2025 at 21:15):fitzgen commented on PR #11933:
(Yes, lots of meetings today, apologies!)
Last updated: Dec 06 2025 at 07:03 UTC