Wasmtime GitHub notifications bot (Mar 05 2020 at 15:22): Wasmtime GitHub notifications bot (Mar 05 2020 at 15:22):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Mar 25 2020 at 21:53):abrown updated PR #1191 from human-readable-encodings to master:
Wasmtime GitHub notifications bot (Mar 31 2020 at 14:34):bnjbvr requested bnjbvr for a review on PR #1191.
Wasmtime GitHub notifications bot (Apr 27 2020 at 08:22):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Apr 27 2020 at 08:22):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Apr 27 2020 at 08:22):bnjbvr created PR Review Comment:
nit: we could use
sort_by_keyhere.
Wasmtime GitHub notifications bot (Apr 27 2020 at 08:22):bnjbvr created PR Review Comment:
ditto for
sort_by_key.
Wasmtime GitHub notifications bot (Apr 27 2020 at 08:22):bnjbvr created PR Review Comment:
Do we rely on remembering the order of insertions? If not, we could use a plain HashMap here.
Wasmtime GitHub notifications bot (Apr 27 2020 at 08:22):bnjbvr created PR Review Comment:
Since this is used only once in the
fmtimpl below, can you inline it there, please?
Wasmtime GitHub notifications bot (Apr 27 2020 at 08:22):bnjbvr created PR Review Comment:
nit:
if let Some(ty) = &self.encoding.bound_type { ...for less verbosity
Wasmtime GitHub notifications bot (Apr 27 2020 at 17:12):abrown closed without merge PR #1191.
Last updated: Nov 22 2024 at 16:03 UTC