bnjbvr submitted PR Review.
abrown updated PR #1191 from human-readable-encodings
to master
:
bnjbvr requested bnjbvr for a review on PR #1191.
bnjbvr submitted PR Review.
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
nit: we could use
sort_by_key
here.
bnjbvr created PR Review Comment:
ditto for
sort_by_key
.
bnjbvr created PR Review Comment:
Do we rely on remembering the order of insertions? If not, we could use a plain HashMap here.
bnjbvr created PR Review Comment:
Since this is used only once in the
fmt
impl below, can you inline it there, please?
bnjbvr created PR Review Comment:
nit:
if let Some(ty) = &self.encoding.bound_type { ...
for less verbosity
abrown closed without merge PR #1191.
Last updated: Dec 23 2024 at 12:05 UTC