Stream: git-wasmtime

Topic: wasmtime / PR #11890 Expose custom page sizes in the C an...

Wasmtime GitHub notifications bot (Oct 20 2025 at 17:50):

fitzgen opened PR #11890 from fitzgen:custom-page-sizes-in-c-api to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 20 2025 at 17:50):

fitzgen requested alexcrichton for a review on PR #11890.

Wasmtime GitHub notifications bot (Oct 20 2025 at 17:50):

fitzgen requested wasmtime-core-reviewers for a review on PR #11890.

Wasmtime GitHub notifications bot (Oct 20 2025 at 17:59):

fitzgen commented on PR #11890:

Oh I think I also need to add the config knob, will do that in a little bit.

Wasmtime GitHub notifications bot (Oct 20 2025 at 18:03):

fitzgen updated PR #11890.

Wasmtime GitHub notifications bot (Oct 20 2025 at 18:20):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2025 at 18:20):

alexcrichton created PR review comment:

Could this be executed from CI, mabe after the formatting check, to ensure this keeps running?

Wasmtime GitHub notifications bot (Oct 20 2025 at 18:20):

alexcrichton created PR review comment:

Is this perhaps due to the *this = MemoryType(..) below? If so could the lines below be updated to avoid needing this conditional? Most of the other bindings using deleter don't use this so I think it'd be good to avoid this one being the odd-one-out.

Wasmtime GitHub notifications bot (Oct 20 2025 at 21:13):

fitzgen requested rvolosatovs for a review on PR #11890.

Wasmtime GitHub notifications bot (Oct 20 2025 at 21:13):

fitzgen updated PR #11890.

Wasmtime GitHub notifications bot (Oct 20 2025 at 21:13):

fitzgen requested wasmtime-default-reviewers for a review on PR #11890.

Wasmtime GitHub notifications bot (Oct 20 2025 at 21:20):

fitzgen has enabled auto merge for PR #11890.

Wasmtime GitHub notifications bot (Oct 20 2025 at 21:52):

fitzgen merged PR #11890.

Last updated: Dec 06 2025 at 07:03 UTC