Stream: git-wasmtime

Topic: wasmtime / PR #11848 docs: Add an example application tha...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2025 at 20:54):

catamorphism opened PR #11848 from catamorphism:docs-plugins-example to bytecodealliance:main:

This PR extends the documentation by adding a walk-through, under the wasip2 section, of an application that embeds Wasmtime in order to use plugins.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2025 at 20:54):

catamorphism requested dicej for a review on PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2025 at 20:54):

catamorphism requested wasmtime-core-reviewers for a review on PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2025 at 20:54):

catamorphism requested wasmtime-default-reviewers for a review on PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2025 at 20:55):

catamorphism commented on PR #11848:

In CI, the code for the application is built as part of the test_capi target and is only built under Linux. This is because it took me a while to get things right, wrt installing wit-bindgen and jco, just for Linux; but if you think it's important to build the code on other platforms, I can try to do that.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2025 at 21:13):

catamorphism updated PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton submitted PR review:

Thanks for this! Running on just Linux I think is fine given the necessary steps in CI

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

This might be a stray file now that it's part of the main workspace?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

Could this have publish = false as well? (might be required to get full CI passing anyway)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

Could this link to the URL-to-be?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

Idiomatically this can be replaced with anyhow::bail!("plugins directory does not exist")

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

Since this is required you can drop the Option and clap will print a nice message if it's missing

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

For these two dependencies could the versions get replaced with workspace = true?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

s/wit-bindgen-cli/wit-bindgen-cli@0.46.0/ (to avoid future theoretical breakage)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

With clap traits here, was the intention to embed this struct directly in the "app" down below?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton created PR review comment:

Similar to wit-bindgen-cli, could this have a version specification to install the same version? (I'm not sure now npm install works myself)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 14:58):

alexcrichton requested alexcrichton for a review on PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:50):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:50):

catamorphism created PR review comment:

Not sure what you mean by "the 'app' down below"?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:55):

catamorphism updated PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:55):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:55):

catamorphism created PR review comment:

Removed in c491ecc

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:55):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:55):

catamorphism created PR review comment:

Added in c491ecc

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism created PR review comment:

Fixed in c491ecc

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism created PR review comment:

Fixed in c491ecc

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism created PR review comment:

Fixed in c491ecc

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism created PR review comment:

Fixed in c491ecc

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 18:56):

catamorphism created PR review comment:

Fixed in c491ecc

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 19:17):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 19:17):

alexcrichton created PR review comment:

Oh sorry, I mean struct Args below and how it duplicates the fields of this BinaryOperation vs having op: BinaryOperation internally. Clap should be able to delegate parsers like that with #[command(flatten)] I believe, but otherwise if the current structure is intended then this #[derive] I think is otherwise unused?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:01):

catamorphism updated PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:01):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:01):

catamorphism created PR review comment:

Ah, got it. Yes, I was trying to do that but whatever I tried initially didn't work. I got it to work this time in e3b9a9e.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:31):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:32):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:32):

alexcrichton created PR review comment:

I assume this was for testing to delete this, but mind re-adding it? (in the future putting prtest:capi in a commit message should work)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:33):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:33):

alexcrichton created PR review comment:

Oh, sorry, final comment -- mind adding this to the action yml which installs the sdk? Should be able to echo WASI_SDK_PATH=... >> $GITHUB_ENV

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:36):

catamorphism updated PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:36):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:36):

catamorphism created PR review comment:

Oops, yes. Fixed in 567fcf5

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:37):

catamorphism submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:37):

catamorphism created PR review comment:

Changed in 567fcf5

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 20:43):

alexcrichton has enabled auto merge for PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 22:00):

catamorphism commented on PR #11848:

The "doc build" failure is odd because the calculator example doesn't build the plugins by default, and this build shouldn't pass in the feature flag that builds the plugins. I'm trying to repro locally.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 22:07):

alexcrichton commented on PR #11848:

Oh I think there's a need for another --exclude on the CI config for that cargo doc command to exclude this new package. Or maybe alternative tag the targets with doc = false so cargo doc --workspace skips it automatically... Either way's fine

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 22:27):

catamorphism updated PR #11848.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2025 at 22:28):

catamorphism commented on PR #11848:

I guess it was getting built with all features enabled because of the --check-cfg flag? Anyway, I added the --exclude.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 15 2025 at 15:53):

alexcrichton merged PR #11848.

Last updated: Dec 06 2025 at 07:03 UTC