Stream: git-wasmtime

Topic: wasmtime / PR #11799 Fix externref/anyref ownership in C/...

Wasmtime GitHub notifications bot (Oct 07 2025 at 14:26):

alexcrichton opened PR #11799 from alexcrichton:fix-c-api-onwership to bytecodealliance:main:

This commit is a follow-up to #11514 which was discovered through failing tests in the wasmtime-py repository when updating to Wasmtime 37.0.0. Effectively a combination of bugs in the Rust API meant that it wasn't possible to use externref or anyref bindings correctly. The Rust changes in this commit are:

• wasmtime_val_unroot correctly drops the value now as opposed to effectively being a noop from before (typo of using as_externref vs from_externref).
• wasmtime_{anyref,externref,val}_t now have a Drop implementation in Rust to correctly drop them if a value in Rust is dropped. This is required to correctly manage memory in the wasmtime_func_{call,new} implementations, for example.
• wasmtime_{anyref,externref,val}_clone no longer have an unnecessary context parameter.
• wasmtime_{anyref,externref,val}_unroot no longer have an unnecessary context parameter.

Changes in the C/C++ APIs are:

• Result::{ok,err}_ref APIs were added in addition to the preexisting rvalue accessors.
• Loading/storing typed arguments now has an overload for const T& and T&& which behaves differently. Notably transferring ownership for T&& and not for const T&. This means that passing parameters when calling a wasm function uses const T&, but passing results from a host import uses T&&.
• TypedFunc::call now uses const Params& instead of Params to explicitly specify it doesn't modify the parameters and forces using the const T& store method.
• Store::gc is now a convenience method for store.context().gc()
• ExternRef, AnyRef, and Val now have ownership semantics and destructors. This matches the spirit of #11514 for Rust but models it in C++ as well. This required filling out move/copy constructors/assignments.
• The explicit ExternRef now takes std::any instead of T.
• Minor issues related to ownership are fixed in Val bindings.

Valgrind was used to ensure that there were no leaks for the test suite which additionally resulted in a number of *_delete calls being added to tests using the C API (accidental omissions).

The original goal of this change was to be a patch release for 37.0.1 to enable updating wasmtime-py to the 37.0.x releases of Wasmtime. In the end though the changes here were broad enough that I no longer feel that this is a good idea, so wasmtime-py will be skipping the 37 version of Wasmtime.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 07 2025 at 14:26):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11799.

Wasmtime GitHub notifications bot (Oct 07 2025 at 14:26):

alexcrichton requested pchickey for a review on PR #11799.

Wasmtime GitHub notifications bot (Oct 07 2025 at 14:29):

alexcrichton updated PR #11799.

Wasmtime GitHub notifications bot (Oct 07 2025 at 14:46):

alexcrichton has enabled auto merge for PR #11799.

Wasmtime GitHub notifications bot (Oct 07 2025 at 14:55):

alexcrichton commented on PR #11799:

Once this lands on main I'll backport the merged commit to the release-38.0.0 branch as well

Wasmtime GitHub notifications bot (Oct 07 2025 at 16:36):

cfallin submitted PR review:

Carrying over my review from the GHSA -- thanks again for catching this and fixing it!

Wasmtime GitHub notifications bot (Oct 07 2025 at 17:03):

alexcrichton merged PR #11799.

Last updated: Dec 06 2025 at 07:03 UTC