Stream: git-wasmtime

Topic: wasmtime / PR #11798 Fix some panics compiling components...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:23):

alexcrichton opened PR #11798 from alexcrichton:fix-compiling-some-resource-types to bytecodealliance:main:

In working on bytecodealliance/wasm-tools#2335 I found that there's a few test cases in wasm-tools which Wasmtime was panicking to compile. The issues were all related to resource types and how information wasn't registered ahead of time before it was translated from wasmparser's representation to Wasmtime's representation. The high-level cause for this had to do with how component and instance types are handled, as opposed to concrete components or instances themselves. This was effectively a hole in Wasmtime's translation process for components which has never been filled out since the original implementation of resources. The reason that this never came up before is:

One of these was required to trigger this issue. The solution implemented in this commit is to plumb the concept of an "abstract resource" which is part of a type but not actually ever used at runtime except for type equality during type reflection. This is expected to have little-to-no impact on real-world components given that these situations are rarely occurring.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:23):

alexcrichton requested cfallin for a review on PR #11798.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:23):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11798.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:23):

alexcrichton requested dicej for a review on PR #11798.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:23):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11798.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:34):

dicej submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:36):

alexcrichton has enabled auto merge for PR #11798.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 06 2025 at 22:59):

alexcrichton merged PR #11798.


Last updated: Dec 06 2025 at 07:03 UTC