Stream: git-wasmtime

Topic: wasmtime / PR #11782 c-api: Fix CMakeLists to work proper...

Wasmtime GitHub notifications bot (Oct 02 2025 at 20:13):

josephg opened PR #11782 from josephg:main to bytecodealliance:main:

The WASMTIME_TARGET check in cmake looks to see if the .dylib path is used. This is used on all apple platforms - including macos ("darwin"), ios and visionos and so on.

$ rustc --print target-list | grep apple
aarch64-apple-darwin
aarch64-apple-ios
aarch64-apple-ios-macabi
aarch64-apple-ios-sim
aarch64-apple-tvos
aarch64-apple-tvos-sim
aarch64-apple-visionos
aarch64-apple-visionos-sim
aarch64-apple-watchos
aarch64-apple-watchos-sim
...

The test currently only checks for darwin, so it only works correctly on macos.

This change fixes the test to support all apple platforms.

Wasmtime GitHub notifications bot (Oct 02 2025 at 20:13):

josephg requested alexcrichton for a review on PR #11782.

Wasmtime GitHub notifications bot (Oct 02 2025 at 20:13):

josephg requested wasmtime-core-reviewers for a review on PR #11782.

Wasmtime GitHub notifications bot (Oct 02 2025 at 20:14):

josephg edited PR #11782:

The WASMTIME_TARGET check in cmake looks to see if the .dylib path is used. This is used on all apple platforms - including macos ("darwin"), ios and visionos and so on.

Fixes #11759

$ rustc --print target-list | grep apple
aarch64-apple-darwin
aarch64-apple-ios
aarch64-apple-ios-macabi
aarch64-apple-ios-sim
aarch64-apple-tvos
aarch64-apple-tvos-sim
aarch64-apple-visionos
aarch64-apple-visionos-sim
aarch64-apple-watchos
aarch64-apple-watchos-sim
...

The test currently only checks for darwin, so it only works correctly on macos.

This change fixes the test to support all apple platforms.

Wasmtime GitHub notifications bot (Oct 02 2025 at 20:45):

alexcrichton commented on PR #11782:

Thanks! There's a few other places in this CMakeLists.txt file that mention "darwin" too, should those change to "apple" as well?

Wasmtime GitHub notifications bot (Oct 03 2025 at 02:19):

josephg commented on PR #11782:

I think so. Essentially Darwin = macOS and Apple includes all other Apple platforms. But at a glance, I’m not sure how necessary those other configuration changes are on other Apple platforms.

But I doubt anyone is currently building Wasmtime for any other Apple platforms at the moment either. There’s also a bug right now building wasmtime with default features on iOS because of a bug in zstd, which is used for the cache feature.

Unfortunately I can’t test it more at the moment because I’m about to get on a cruise ship for a few weeks of vacation. I’d be happy to merge this PR as is. Or if you feel like it, change all of them to apple and we can tweak as needed once I have time to do some more test builds. I think that’s the right choice, I just can’t test it for the next few weeks. When I get back I want to put together an example app integrating wasmtime into a native Swift app - and that’ll shake out any other problems.

Wasmtime GitHub notifications bot (Oct 03 2025 at 15:51):

alexcrichton submitted PR review:

Ok sounds reasonable! I'll send a follow-up and if you can test when you get back that'd be much appreciated!

Wasmtime GitHub notifications bot (Oct 03 2025 at 16:13):

alexcrichton merged PR #11782.

Last updated: Dec 06 2025 at 07:03 UTC