Stream: git-wasmtime

Topic: wasmtime / PR #11766 Fix reverse PC to function lookups f...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:47):

fitzgen opened PR #11766 from fitzgen:issue-11749-func-lookup-panic to bytecodealliance:main:

We were previously computing an offset within the kind's sparse index space, and needed to add its sparse start index to get the actual SparseIndex for the function.

Fixes #11749
Fixes #11750 (contains that PR's commit)

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:47):

fitzgen requested cfallin for a review on PR #11766.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:47):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #11766.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:47):

fitzgen requested dicej for a review on PR #11766.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:47):

fitzgen requested wasmtime-core-reviewers for a review on PR #11766.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:47):

fitzgen requested wasmtime-default-reviewers for a review on PR #11766.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:50):

fitzgen commented on PR #11766:

FYI: I verified that this fixes the original test case from #11749 but did not include it as a wast test case here because I wasn't able to capture all the CLI flags that are required to repro into a wast test. I don't think this is a big deal however because the arbtest that @alexcrichton wrote (thank you!) quickly and easily reproduces the bug. I also checked that running the arbtest for an extended period of time (aka fuzzing) did not produce any failures.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:51):

fitzgen commented on PR #11766:

Also, this bug hasn't made it into any release branch yet, so no need to backport anything.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:53):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 18:55):

fitzgen has enabled auto merge for PR #11766.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 30 2025 at 19:22):

fitzgen merged PR #11766.

Last updated: Dec 06 2025 at 06:05 UTC