Stream: git-wasmtime

Topic: wasmtime / PR #11691 change `Network::check_socket_addr` ...

Wasmtime GitHub notifications bot (Sep 12 2025 at 16:33):

dicej requested alexcrichton for a review on PR #11691.

Wasmtime GitHub notifications bot (Sep 12 2025 at 16:33):

dicej requested wasmtime-wasi-reviewers for a review on PR #11691.

Wasmtime GitHub notifications bot (Sep 12 2025 at 16:33):

dicej opened PR #11691 from dicej:pub-network-check-socket-addr to bytecodealliance:main:

https://github.com/bytecodealliance/wasmtime/pull/11379 changed it from pub to pub(crate), which breaks external users of that function. Since the Network type itself is pub and not very useful without any pub fields or functions, I'm switching it back.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 12 2025 at 16:49):

dicej has enabled auto merge for PR #11691.

Wasmtime GitHub notifications bot (Sep 12 2025 at 18:26):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 12 2025 at 18:49):

dicej merged PR #11691.

Last updated: Dec 06 2025 at 07:03 UTC