Wasmtime GitHub notifications bot (Sep 10 2025 at 05:45): Wasmtime GitHub notifications bot (Sep 10 2025 at 05:45):bongjunj opened PR #11663 from bongjunj:fold-and-xor-not to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->This considers all commutative LHS cases of
(x ^ ~y) & x --> x & y.
Corresponding egraph filetests are added too.;; (x ^ ~y) & x --> x & y (rule (simplify (band ty (bxor ty x (bnot ty y)) x)) (band ty x y)) (rule (simplify (band ty (bxor ty (bnot ty y) x) x)) (band ty x y)) (rule (simplify (band ty x (bxor ty x (bnot ty y)))) (band ty x y)) (rule (simplify (band ty x (bxor ty (bnot ty y) x))) (band ty x y))
Wasmtime GitHub notifications bot (Sep 10 2025 at 05:45):bongjunj requested fitzgen for a review on PR #11663.
Wasmtime GitHub notifications bot (Sep 10 2025 at 05:45):bongjunj requested wasmtime-compiler-reviewers for a review on PR #11663.
Wasmtime GitHub notifications bot (Sep 10 2025 at 05:45):bongjunj edited PR #11663:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->This considers all commutative LHS cases of
(x ^ ~y) & x --> x & y. (#11642)
Corresponding egraph filetests are added too.;; (x ^ ~y) & x --> x & y (rule (simplify (band ty (bxor ty x (bnot ty y)) x)) (band ty x y)) (rule (simplify (band ty (bxor ty (bnot ty y) x) x)) (band ty x y)) (rule (simplify (band ty x (bxor ty x (bnot ty y)))) (band ty x y)) (rule (simplify (band ty x (bxor ty (bnot ty y) x))) (band ty x y))
Wasmtime GitHub notifications bot (Sep 10 2025 at 08:47):github-actions[bot] commented on PR #11663:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Sep 10 2025 at 20:04):fitzgen submitted PR review:
Looks great but I think there are some conflicts here as well.
Wasmtime GitHub notifications bot (Sep 11 2025 at 00:43):bongjunj updated PR #11663.
Wasmtime GitHub notifications bot (Sep 11 2025 at 00:45):bongjunj commented on PR #11663:
Rebased on https://github.com/bytecodealliance/wasmtime/pull/11641.
All the conflicts should be resolved after #11641 is merged.
Wasmtime GitHub notifications bot (Sep 11 2025 at 07:20):bongjunj updated PR #11663.
Wasmtime GitHub notifications bot (Sep 11 2025 at 17:27):fitzgen merged PR #11663.
Last updated: Dec 06 2025 at 06:05 UTC