Stream: git-wasmtime

Topic: wasmtime / PR #11655 don't delete sync-lowered subtasks u...

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:04):

dicej opened PR #11655 from dicej:sync-lower-subtask-lifecycle to bytecodealliance:main:

Previously, we were unconditionally deleting the callee subtask once it returned a value to a sync-lowered call, but that's only appropriate if the subtask has exited. Otherwise, it needs to keep running and only be deleted once it actually exits.

Thanks to Luke for the sync-streams.wast test that uncovered this, which I've copied from the component-model repo.

This also makes a couple of debug logging tweaks that proved useful while investigating the above issue.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:04):

dicej requested wasmtime-core-reviewers for a review on PR #11655.

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:04):

dicej requested alexcrichton for a review on PR #11655.

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:40):

dicej updated PR #11655.

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:41):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:41):

alexcrichton has enabled auto merge for PR #11655.

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:43):

alexcrichton edited PR #11655:

Previously, we were unconditionally deleting the callee subtask once it returned a value to a sync-lowered call, but that's only appropriate if the subtask has exited. Otherwise, it needs to keep running and only be deleted once it actually exits.

Thanks to Luke for the sync-streams.wast test that uncovered this, which I've copied from the component-model repo.

This also makes a couple of debug logging tweaks that proved useful while investigating the above issue.

Closes #11611

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 09 2025 at 17:37):

alexcrichton merged PR #11655.

Last updated: Dec 06 2025 at 06:05 UTC