Stream: git-wasmtime

Topic: wasmtime / PR #11654 [37.0.0] More WASIp3 backports

Wasmtime GitHub notifications bot (Sep 09 2025 at 15:46):

alexcrichton opened PR #11654 from alexcrichton:more-backports to bytecodealliance:release-37.0.0:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 09 2025 at 15:46):

alexcrichton requested wasmtime-wasi-reviewers for a review on PR #11654.

Wasmtime GitHub notifications bot (Sep 09 2025 at 15:46):

alexcrichton requested dicej for a review on PR #11654.

Wasmtime GitHub notifications bot (Sep 09 2025 at 15:46):

alexcrichton requested wasmtime-core-reviewers for a review on PR #11654.

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:02):

alexcrichton commented on PR #11654:

cc @rvolosatovs this failure looks like a spurious flake in wasi-http tests (I can retry it but I don't want to lose it either):

---- p3::p3_http_outbound_request_content_length stdout ----
worker failed with error error from user's Body stream

Caused by:
    0: error reading a body from connection
    1: end of file before message length reached
Error: failed to call `wasi:cli/run#run`

Caused by:
    0: error while executing at wasm backtrace:
           0:  0x68d1c - panic_abort::__rust_start_panic::abort::hfa521bba89ce5759
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/panic_abort/src/lib.rs:113:17

                       - __rustc[95feac21a9532783]::__rust_start_panic
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/panic_abort/src/lib.rs:49:9
           1:  0x68b8d - __rustc[95feac21a9532783]::rust_panic
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:894:25
           2:  0x68b60 - std::panicking::rust_panic_with_hook::hc20fbdbadfcc1625
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:858:5
           3:  0x67b76 - std::panicking::begin_panic_handler::{{closure}}::h1237330613601c3b
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:706:13
           4:  0x67ae2 - std::sys::backtrace::__rust_end_short_backtrace::h207b568e8da931a1
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/sys/backtrace.rs:168:18
           5:  0x684f3 - __rustc[95feac21a9532783]::rust_begin_unwind
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:697:5
           6:  0x6d541 - core::panicking::panic_fmt::he093f8ef6966d6c7
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/panicking.rs:75:14
           7:  0x6f37d - core::result::unwrap_failed::h1bc014930691ddf4
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/result.rs:1704:5
           8:   0xacac - core::result::Result<T,E>::expect_err::h4dc44849308773ac
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/result.rs:1172:22
           9:  0x24154 - <p3_http_outbound_request_content_length::Component as test_programs::p3::exports::wasi::cli::run::Guest>::run::{{closure}}::h667ad4c0ebe40218
                           at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/bin/p3_http_outbound_request_content_length.rs:113:23
          10:   0x6462 - test_programs::p3::exports::wasi::cli::run::_export_run_cabi::{{closure}}::h09fcbd8e6973714c
                           at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/p3/mod.rs:4:1
          11:  0x5b72d - <core::pin::Pin<P> as core::future::future::Future>::poll::h245dcf4b3ca770e1
                           at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/future/future.rs:124:9

                       - <futures_util::stream::futures_unordered::FuturesUnordered<Fut> as futures_core::stream::Stream>::poll_next::hcea85e06fb1b7f9f
                           at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/stream/futures_unordered/mod.rs:528:17
          12:  0x5adec - futures_util::stream::stream::StreamExt::poll_next_unpin::h1fd061b6541c9252
                           at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/stream/stream/mod.rs:1638:9

                       - wit_bindgen::rt::async_support::FutureState::poll::{{closure}}::h530bc3620a250b26
                           at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:182:28

                       - wit_bindgen::rt::async_support::FutureState::with_p3_task_set::h7bb4c3253b380010
                           at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:237:9

                       - wit_bindgen::rt::async_support::FutureState::poll::h5ea42f12fe68d819
                           at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:171:9

                       - wit_bindgen::rt::async_support::FutureState::callback::h029d8768fc21ec15
                           at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:151:9
          13:  0x5b112 - wit_bindgen::rt::async_support::callback::h735e0c385c706a91
                           at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:400:26
          14:  0x2951d - test_programs::p3::exports::wasi::cli::run::__callback_run::h2122a0f968825060
                           at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/p3/mod.rs:4:1
          15:  0x24516 - [callback][async-lift]wasi:cli/run@0.3.0-rc-2025-08-15#run
                           at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/bin/p3_http_outbound_request_content_length.rs:9:1
    1: wasm trap: wasm `unreachable` instruction executed


failures:
    p3::p3_http_outbound_request_content_length

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:20):

rvolosatovs commented on PR #11654:

cc @rvolosatovs this failure looks like a spurious flake in wasi-http tests (I can retry it but I don't want to lose it either):

```
---- p3::p3_http_outbound_request_content_length stdout ----
worker failed with error error from user's Body stream

Caused by:
0: error reading a body from connection
1: end of file before message length reached
Error: failed to call wasi:cli/run#run

Caused by:
0: error while executing at wasm backtrace:
0: 0x68d1c - panic_abort::__rust_start_panic::abort::hfa521bba89ce5759
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/panic_abort/src/lib.rs:113:17
- __rustc[95feac21a9532783]::__rust_start_panic
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/panic_abort/src/lib.rs:49:9
1: 0x68b8d - __rustc[95feac21a9532783]::rust_panic
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:894:25
2: 0x68b60 - std::panicking::rust_panic_with_hook::hc20fbdbadfcc1625
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:858:5
3: 0x67b76 - std::panicking::begin_panic_handler::{{closure}}::h1237330613601c3b
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:706:13
4: 0x67ae2 - std::sys::backtrace::__rust_end_short_backtrace::h207b568e8da931a1
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/sys/backtrace.rs:168:18
5: 0x684f3 - __rustc[95feac21a9532783]::rust_begin_unwind
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:697:5
6: 0x6d541 - core::panicking::panic_fmt::he093f8ef6966d6c7
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/panicking.rs:75:14
7: 0x6f37d - core::result::unwrap_failed::h1bc014930691ddf4
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/result.rs:1704:5
8: 0xacac - core::result::Result<T,E>::expect_err::h4dc44849308773ac
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/result.rs:1172:22
9: 0x24154 - <p3_http_outbound_request_content_length::Component as test_programs::p3::exports::wasi::cli::run::Guest>::run::{{closure}}::h667ad4c0ebe40218
at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/bin/p3_http_outbound_request_content_length.rs:113:23
10: 0x6462 - test_programs::p3::exports::wasi::cli::run::_export_run_cabi::{{closure}}::h09fcbd8e6973714c
at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/p3/mod.rs:4:1
11: 0x5b72d - <core::pin::Pin<P> as core::future::future::Future>::poll::h245dcf4b3ca770e1
at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/future/future.rs:124:9
- <futures_util::stream::futures_unordered::FuturesUnordered<Fut> as futures_core::stream::Stream>::poll_next::hcea85e06fb1b7f9f
at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/stream/futures_unordered/mod.rs:528:17
12: 0x5adec - futures_util::stream::stream::StreamExt::poll_next_unpin::h1fd061b6541c9252
at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/stream/stream/mod.rs:1638:9
- wit_bindgen::rt::async_support::FutureState::poll::{{closure}}::h530bc3620a250b26
at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:182:28
- wit_bindgen::rt::async_support::FutureState::with_p3_task_set::h7bb4c3253b380010
at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:237:9
- wit_bindgen::rt::async_support::FutureState::poll::h5ea42f12fe68d819
at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:171:9
- wit_bindgen::rt::async_support::FutureState::callback::h029d8768fc21ec15
at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:151:9
13: 0x5b112 - wit_bindgen::rt::async_support::callback::h735e0c385c706a91
at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wit-bindgen-0.45.0/src/rt/async_support.rs:400:26
14: 0x2951d - test_programs::p3::exports::wasi::cli::run::__callback_run::h2122a0f968825060
at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/p3/mod.rs:4:1
15: 0x24516 - [callback][async-lift]wasi:cli/run@0.3.0-rc-2025-08-15#run
at /home/runner/work/wasmtime/wasmtime/crates/test-programs/src/bin/p3_http_outbound_request_content_length.rs:9:1
1: wasm trap: wasm unreachable instruction executed

failures:
p3::p3_http_outbound_request_content_length
```

The fix is not entirely obvious, in fact I'm quite confused how the transmit future could have not failed while the handle one did. I'll have to reproduce this locally

Wasmtime GitHub notifications bot (Sep 09 2025 at 18:00):

alexcrichton updated PR #11654.

Wasmtime GitHub notifications bot (Sep 09 2025 at 18:01):

alexcrichton has enabled auto merge for PR #11654.

Wasmtime GitHub notifications bot (Sep 09 2025 at 19:05):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Sep 09 2025 at 19:05):

alexcrichton merged PR #11654.

Last updated: Dec 06 2025 at 06:05 UTC