Stream: git-wasmtime

Topic: wasmtime / PR #11648 [Cranelift] folds 3 selects into 2 s...

Wasmtime GitHub notifications bot (Sep 09 2025 at 01:14):

bongjunj opened PR #11648 from bongjunj:fold-3-selects to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 09 2025 at 01:14):

bongjunj requested cfallin for a review on PR #11648.

Wasmtime GitHub notifications bot (Sep 09 2025 at 01:14):

bongjunj requested wasmtime-compiler-reviewers for a review on PR #11648.

Wasmtime GitHub notifications bot (Sep 09 2025 at 03:03):

github-actions[bot] commented on PR #11648:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 09 2025 at 15:47):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 09 2025 at 16:06):

cfallin created PR review comment:

It seems like the (select ty c x y) (the nested select) is unimportant to the left-hand side, since it is just passed through as an opaque value / preserved as the first arg on the output?

Could we generalize this to

(rule (simplify (select ty d a (select ty d x y)))
                (select ty d a y))

in other words, "path-sensitive constant propagating" d to be always-false in the second select input?

Likewise for the symmetrical case, with a nested select in the first input...

Wasmtime GitHub notifications bot (Sep 10 2025 at 01:15):

bongjunj created PR review comment:

I see you're right. I'm gonna update this PR. Thanks!

Wasmtime GitHub notifications bot (Sep 10 2025 at 01:15):

bongjunj submitted PR review.

Wasmtime GitHub notifications bot (Sep 10 2025 at 06:31):

bongjunj updated PR #11648.

Wasmtime GitHub notifications bot (Sep 10 2025 at 06:37):

bongjunj updated PR #11648.

Last updated: Dec 06 2025 at 06:05 UTC