Stream: git-wasmtime

Topic: wasmtime / PR #11642 [Cranelift] fold `(and (xor (not ..)...

Wasmtime GitHub notifications bot (Sep 08 2025 at 13:40):

bongjunj opened PR #11642 from bongjunj:fold-and-xor-not to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 08 2025 at 13:40):

bongjunj requested wasmtime-compiler-reviewers for a review on PR #11642.

Wasmtime GitHub notifications bot (Sep 08 2025 at 13:40):

bongjunj requested fitzgen for a review on PR #11642.

Wasmtime GitHub notifications bot (Sep 08 2025 at 14:46):

github-actions[bot] commented on PR #11642:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 09 2025 at 17:26):

fitzgen submitted PR review:

Thanks! Inline suggestion below that can happen as a followup PR, if you'd like.

Wasmtime GitHub notifications bot (Sep 09 2025 at 17:26):

fitzgen created PR review comment:

ISLE doesn't automatically generate rules for matching commutative operations right now, so it may be worth manually enumerating the equivalent commutative versions here, e.g.:

(rule (simplify (band ty x (bxor ty x (bnot ty y)))) (band ty x y))
(rule (simplify (band ty (bxor ty (bnot ty y) x) x)) (band ty x y))
(rule (simplify (band ty (bxor ty x (bnot ty y)) x)) (band ty x y))

Wasmtime GitHub notifications bot (Sep 09 2025 at 17:54):

fitzgen merged PR #11642.

Last updated: Dec 06 2025 at 06:05 UTC