Stream: git-wasmtime

Topic: wasmtime / PR #11588 Use a wrapping add in egraph optimiz...

Wasmtime GitHub notifications bot (Sep 02 2025 at 14:38):

alexcrichton opened PR #11588 from alexcrichton:fix-isle-fuzz-bug to bytecodealliance:main:

This commit fixes an accidental bug from #11526 found via fuzzing where the u64_add helper in ISLE is a panicking add but the desired semantics here were a wrapping add. A test is added here and the additions are updated to u64_wrapping_add instead.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 02 2025 at 14:38):

alexcrichton requested fitzgen for a review on PR #11588.

Wasmtime GitHub notifications bot (Sep 02 2025 at 14:38):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #11588.

Wasmtime GitHub notifications bot (Sep 02 2025 at 14:40):

alexcrichton updated PR #11588.

Wasmtime GitHub notifications bot (Sep 02 2025 at 15:45):

github-actions[bot] commented on PR #11588:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Sep 03 2025 at 17:44):

alexcrichton requested cfallin for a review on PR #11588.

Wasmtime GitHub notifications bot (Sep 03 2025 at 17:55):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 03 2025 at 18:18):

cfallin merged PR #11588.

Last updated: Dec 06 2025 at 06:05 UTC