Stream: git-wasmtime

Topic: wasmtime / PR #11558 Call `fixup` before `to_wasm_binary`...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2025 at 20:35):

fitzgen opened PR #11558 from fitzgen:fixup-table-ops-in-to-wasm-binary to bytecodealliance:main:

Rather than just after particular mutations. Because mutating the serialized bytes can also result in invalid and out-of-bounds TableOps instances. This just does the fixup in the one place, instead of needing to remember all the different places where we might need to do it.

cc @khagankhan

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2025 at 20:35):

fitzgen requested alexcrichton for a review on PR #11558.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2025 at 20:35):

fitzgen requested wasmtime-fuzz-reviewers for a review on PR #11558.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2025 at 20:36):

fitzgen commented on PR #11558:

Also a few random code clean ups: pulling the fixing up of limits into TableOpsLimits::fixup, etc...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2025 at 20:45):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 28 2025 at 21:46):

fitzgen merged PR #11558.


Last updated: Dec 06 2025 at 06:05 UTC