Stream: git-wasmtime

Topic: wasmtime / PR #11521 [Cranelift] `(x - y) u> x --> y u> x`

Wasmtime GitHub notifications bot (Aug 25 2025 at 01:38):

bongjunj opened PR #11521 from bongjunj:sub-ugt-to-swapped-ugt to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

This adds an optimization: (X - Y) u> X --> Y u> X.
Same proof with crocus is used to verify the correctness. (See my previous PR #11359)

Wasmtime GitHub notifications bot (Aug 25 2025 at 01:39):

bongjunj requested wasmtime-compiler-reviewers for a review on PR #11521.

Wasmtime GitHub notifications bot (Aug 25 2025 at 01:39):

bongjunj requested fitzgen for a review on PR #11521.

Wasmtime GitHub notifications bot (Aug 25 2025 at 01:45):

bongjunj updated PR #11521.

Wasmtime GitHub notifications bot (Aug 25 2025 at 03:10):

github-actions[bot] commented on PR #11521:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Aug 25 2025 at 18:16):

fitzgen submitted PR review:

Looks great, thanks!

Would you mind also adding a runtest for this rule (and for other rules you add, going forward, please) so that we can test the behavior under the non-optimizing interpreted CLIF and make sure it matches the results of the optimized and compiled to native code version? Anywhere under cranelift/filetests/filetests/runtests/* would be fine.

Will merge once that test is added. Thanks again!

Wasmtime GitHub notifications bot (Aug 27 2025 at 00:39):

bongjunj updated PR #11521.

Wasmtime GitHub notifications bot (Aug 27 2025 at 00:41):

bongjunj commented on PR #11521:

Hi, thank you for the review.

I've just added runtests for the new opts.

Wasmtime GitHub notifications bot (Aug 27 2025 at 15:19):

fitzgen submitted PR review:

Fantastic, thanks again @bongjunj!

Wasmtime GitHub notifications bot (Aug 27 2025 at 16:02):

fitzgen merged PR #11521.

Last updated: Dec 06 2025 at 06:05 UTC